A number of small issues regarding the default battle systems

I posted a bug report of various things found in battles over at the GitHub, but for some reason the issue doesn’t seem to be visible for anyone else (https://github.com/EasyRPG/Player/issues/3490), so maybe sharing them again here could resolve that. It’s a collection of smaller errors I came across while meddling with the battle systems in both 2k and 2k3 environments. All of these were tested with EasyRPG Player 0.8.1.1 on Windows 11.

  • In any engine/battle system: Displaying a picture on battle layer 0 (above background) from outside the battle shows it above battlers instead. Further testing revealed that it gets set correctly if also put on map layer 0, while being above battlers again with other map layers set, suggesting that the picture may erroneously display as if on the corresponding map layer (if set, otherwise might default to 6). This doesn’t happen when showing a picture inside the battle on turn 0 instead (however, this only acts after the battle scene is already visible). RPG_RT displays the picture as intended.
  • Only in 2k battle system: Selecting an actor to use an item on someone else, then aborting item usage leads to the party member selector to be stuck on the target’s line as if it was their turn. This seems to be purely visual though. In RPG_RT the selector jumps back to the active user as expected.
  • Also only relevant for 2k: If an enemy dies in the same round an actor is set to use a skill on it that displays a %O (enemy name) in its message, while the skill itself is redirected to the next alive foe, the name in the message still shows up as the originally selected one’s. RPG_RT correctly switches to the new target’s name.

The following occur when making use of the 2k battle system within a 2k3 project via manual editing of the database converted to xml format. I understand that this is an experimental feature, however seeing most of its features working well it might be of interest to catch these cases.

  • When making use of the “easyrpg_battle_use_rpg2ke_strings” option that enables placeholders in strings such as %S, the strings for levelling up and learning a skill (both found in the database tab Terms: Battle2) don’t seem to recognize the format, with the level up message also featuring an odd doubled space between the actor’s name and the set message [this turned out to also appear in 2k3 battles].

  • Killing enemies via commands by either setting their state to defeated, or reducing HP and allowing knockout, both result in a complete halt of the game. Even if commands follow, none of them seem to execute, indicating that the battle stops right at the moment of an enemy’s “unnatural” death. This only occurs with 2k battles enabled in a 2k3 project and not for pure 2k or 2k3 cases.

In addition to that, another quirk came along with using Maniacs Patch:

  • With the Control Battle command set to either “damage pop” or “set state”, neither option triggers when the last enemy dies, with the battle instead ending immediately. In cases such as using the trigger to display damage values for example, the last hit always won’t be acted upon this way. The Maniacs runtime, on the other hand, does actually execute the called code still before ending the battle.

Thanks for the report! Will take a look at the concerte issues later.

About the missing issue on GitHub: I have no idea how that happened. I checked the audit log of the organisation and it doesn’t mention any issue creation or deletion at all.

A few days GitHub had issues and generated spurious server errors. Maybe your issue was “eaten” by one of these problems. Very unfortunate :confused:

Thanks for your reply!

I just opened another issue on GitHub for a newly found bug (https://github.com/EasyRPG/Player/issues/3493) and again, it doesn’t show up anywhere outside my own profile. Maybe there is some sort of check needed to make the post public, perhaps something to do with me just having created the profile? I’m completely new to GitHub unfortunately and don’t quite understand how it works yet.

Could you try to contact the GitHub support? My guess is that your account is “shadowbanned”, maybe it is too new or you use a suspicious mail address or they don’t like your country.

(And nothing in the logfiles again. I wonder now how many issues we have missed thanks to this “feature”)

Ok I’m really lost with GitHub. The information I managed to gather so far is:

  • Apparently my (very new) account was “flagged” or “marked” with no clear idea what that means, but is probably the cause of posts being hidden. The account itself offers no indication of any problems.
  • Trying to contact GitHub support keeps asking for personal information. I’ve added 2FA but am not willing to give out my phone number just for the sake of posting some text online, that sounds ridiculous.
  • I can’t seem to find any other way to potentially resolve the issue, with neither the AI chatbot nor community forums offering solutions other than directly contacting support, which is currently a dead end.

Using GitHub to report bugs seemed like a more direct way to give feedback, but with so many hoops to go through (and an awful lot of redirection to places that didn’t help all over the website) the whole thing leaves me very frustrated and exhausted.

Creating a new topic in this forum for every potential bug seems a bit much, but is there another way to directly report findings, like the EasyRPG Discord server?

Very unfortunate that you couldn’t resolve it. Posting it in the forum is better than in the Discord. In the chat we usually forget about issues after a few days. (because nobody writes them down and they scroll away)

You can discuss bugs in the Discord / Chat but for tracking the state of bugs a topic here is more suitable. (or alternatively report all bugs here as replies and I will try to split them in suitable issues on GitHub)